From b45a163b9d9c58d14f170ae386fc8377997cefbc Mon Sep 17 00:00:00 2001 From: Simon John Date: Sat, 29 Nov 2014 22:31:49 +0000 Subject: Removed all double-quoting except for comments/echo's Double-quoting was added in 7618da7 to allow for spaces in paths, that was a bad idea as: 1. most GNU Make functions can't handle spaces 2. it breaks variable expansion on Linux/OSX e.g. ~/sketchbook 3. Windows doesn't like double-quotes - see d5c7ed1 So basically, don't put spaces in your paths, as most Make functions can't handle them, even if escaped, and its a bit dangerous when shelling out to grep etc. Single-quoting is no better either. --- HISTORY.md | 1 + 1 file changed, 1 insertion(+) (limited to 'HISTORY.md') diff --git a/HISTORY.md b/HISTORY.md index 80c48b5..cc563f6 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -37,6 +37,7 @@ I tried to give credit whenever possible. If I have missed anyone, kindly add it - Fix: Changed IDE download URL *again* for Travis-CI. (https://github.com/sej7278) - Fix: Allow avrdude to erase the chip before programming during ispload (https://github.com/tchebb) - Fix: Fix speed regression. Thanks ladislas (Issue #280) (https://github.com/sej7278) +- Fix: Removed some double quotes that were breaking variable expansion. (https://github.com/sej7278) ### 1.3.4 (2014-07-12) - Tweak: Allow spaces in "Serial.begin (....)". (Issue #190) (https://github.com/pdav) -- cgit v1.2.3